123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334 |
- diff --git a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc b/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
- index 8202df66a..277934322 100644
- --- a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
- +++ b/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
- @@ -145,34 +145,34 @@ bool RenderViewContextMenuViews::GetAcceleratorForCommandId(
- return true;
-
- case IDC_CONTENT_CONTEXT_UNDO:
- - *accel = ui::Accelerator(ui::VKEY_Z, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_Z, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_REDO:
- // TODO(jcampan): should it be Ctrl-Y?
- *accel = ui::Accelerator(ui::VKEY_Z,
- - ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN);
- + ui::EF_SHIFT_DOWN | ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_CUT:
- - *accel = ui::Accelerator(ui::VKEY_X, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_X, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_COPY:
- - *accel = ui::Accelerator(ui::VKEY_C, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_C, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_PASTE:
- - *accel = ui::Accelerator(ui::VKEY_V, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_V, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_PASTE_AND_MATCH_STYLE:
- *accel = ui::Accelerator(ui::VKEY_V,
- - ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN);
- + ui::EF_SHIFT_DOWN | ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_SELECTALL:
- - *accel = ui::Accelerator(ui::VKEY_A, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_A, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_ROTATECCW:
- @@ -188,16 +188,16 @@ bool RenderViewContextMenuViews::GetAcceleratorForCommandId(
- return true;
-
- case IDC_PRINT:
- - *accel = ui::Accelerator(ui::VKEY_P, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_P, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_RELOAD:
- - *accel = ui::Accelerator(ui::VKEY_R, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_R, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_SAVEAVAS:
- case IDC_SAVE_PAGE:
- - *accel = ui::Accelerator(ui::VKEY_S, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_S, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_EXIT_FULLSCREEN: {
- @@ -230,7 +230,7 @@ bool RenderViewContextMenuViews::GetAcceleratorForCommandId(
- }
-
- case IDC_VIEW_SOURCE:
- - *accel = ui::Accelerator(ui::VKEY_U, ui::EF_CONTROL_DOWN);
- + *accel = ui::Accelerator(ui::VKEY_U, ui::EF_PLATFORM_ACCELERATOR);
- return true;
-
- case IDC_CONTENT_CONTEXT_EMOJI:
- diff --git a/third_party/blink/renderer/core/editing/editing_behavior.cc b/third_party/blink/renderer/core/editing/editing_behavior.cc
- index 6b7a35b5b..4e0611418 100644
- --- a/third_party/blink/renderer/core/editing/editing_behavior.cc
- +++ b/third_party/blink/renderer/core/editing/editing_behavior.cc
- @@ -44,7 +44,7 @@ const unsigned kCtrlKey = WebInputEvent::kControlKey;
- const unsigned kAltKey = WebInputEvent::kAltKey;
- const unsigned kShiftKey = WebInputEvent::kShiftKey;
- const unsigned kMetaKey = WebInputEvent::kMetaKey;
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- // Aliases for the generic key defintions to make kbd shortcuts definitions more
- // readable on OS X.
- const unsigned kOptionKey = kAltKey;
- @@ -87,7 +87,7 @@ struct DomKeyKeyDownEntry {
- const KeyboardCodeKeyDownEntry kKeyboardCodeKeyDownEntries[] = {
- {VKEY_LEFT, 0, "MoveLeft"},
- {VKEY_LEFT, kShiftKey, "MoveLeftAndModifySelection"},
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- {VKEY_LEFT, kOptionKey, "MoveWordLeft"},
- {VKEY_LEFT, kOptionKey | kShiftKey, "MoveWordLeftAndModifySelection"},
- #else
- @@ -96,7 +96,7 @@ const KeyboardCodeKeyDownEntry kKeyboardCodeKeyDownEntries[] = {
- #endif
- {VKEY_RIGHT, 0, "MoveRight"},
- {VKEY_RIGHT, kShiftKey, "MoveRightAndModifySelection"},
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- {VKEY_RIGHT, kOptionKey, "MoveWordRight"},
- {VKEY_RIGHT, kOptionKey | kShiftKey, "MoveWordRightAndModifySelection"},
- #else
- @@ -109,7 +109,7 @@ const KeyboardCodeKeyDownEntry kKeyboardCodeKeyDownEntries[] = {
- {VKEY_DOWN, 0, "MoveDown"},
- {VKEY_DOWN, kShiftKey, "MoveDownAndModifySelection"},
- {VKEY_NEXT, kShiftKey, "MovePageDownAndModifySelection"},
- -#if !BUILDFLAG(IS_MAC)
- +#if !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_LINUX)
- {VKEY_UP, kCtrlKey, "MoveParagraphBackward"},
- {VKEY_UP, kCtrlKey | kShiftKey, "MoveParagraphBackwardAndModifySelection"},
- {VKEY_DOWN, kCtrlKey, "MoveParagraphForward"},
- @@ -119,32 +119,32 @@ const KeyboardCodeKeyDownEntry kKeyboardCodeKeyDownEntries[] = {
- #endif
- {VKEY_HOME, 0, "MoveToBeginningOfLine"},
- {VKEY_HOME, kShiftKey, "MoveToBeginningOfLineAndModifySelection"},
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- {VKEY_PRIOR, kOptionKey, "MovePageUp"},
- {VKEY_NEXT, kOptionKey, "MovePageDown"},
- #endif
- -#if !BUILDFLAG(IS_MAC)
- +#if !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_LINUX)
- {VKEY_HOME, kCtrlKey, "MoveToBeginningOfDocument"},
- {VKEY_HOME, kCtrlKey | kShiftKey,
- "MoveToBeginningOfDocumentAndModifySelection"},
- #endif
- {VKEY_END, 0, "MoveToEndOfLine"},
- {VKEY_END, kShiftKey, "MoveToEndOfLineAndModifySelection"},
- -#if !BUILDFLAG(IS_MAC)
- +#if !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_LINUX)
- {VKEY_END, kCtrlKey, "MoveToEndOfDocument"},
- {VKEY_END, kCtrlKey | kShiftKey, "MoveToEndOfDocumentAndModifySelection"},
- #endif
- {VKEY_BACK, 0, "DeleteBackward"},
- {VKEY_BACK, kShiftKey, "DeleteBackward"},
- {VKEY_DELETE, 0, "DeleteForward"},
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- {VKEY_BACK, kOptionKey, "DeleteWordBackward"},
- {VKEY_DELETE, kOptionKey, "DeleteWordForward"},
- #else
- {VKEY_BACK, kCtrlKey, "DeleteWordBackward"},
- {VKEY_DELETE, kCtrlKey, "DeleteWordForward"},
- #endif
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- {'B', kCommandKey, "ToggleBold"},
- {'I', kCommandKey, "ToggleItalic"},
- #else
- @@ -167,14 +167,14 @@ const KeyboardCodeKeyDownEntry kKeyboardCodeKeyDownEntries[] = {
- #if !BUILDFLAG(IS_MAC)
- // On OS X, we pipe these back to the browser, so that it can do menu item
- // blinking.
- - {'C', kCtrlKey, "Copy"},
- - {'V', kCtrlKey, "Paste"},
- - {'V', kCtrlKey | kShiftKey, "PasteAndMatchStyle"},
- - {'X', kCtrlKey, "Cut"},
- - {'A', kCtrlKey, "SelectAll"},
- - {'Z', kCtrlKey, "Undo"},
- - {'Z', kCtrlKey | kShiftKey, "Redo"},
- - {'Y', kCtrlKey, "Redo"},
- + {'C', kCommandKey, "Copy"},
- + {'V', kCommandKey, "Paste"},
- + {'V', kCommandKey | kShiftKey, "PasteAndMatchStyle"},
- + {'X', kCommandKey, "Cut"},
- + {'A', kCommandKey, "SelectAll"},
- + {'Z', kCommandKey, "Undo"},
- + {'Z', kCommandKey | kShiftKey, "Redo"},
- + {'Y', kCommandKey, "Redo"},
- #endif
- #if BUILDFLAG(IS_WIN)
- {VKEY_BACK, kAltKey, "Undo"},
- @@ -280,19 +280,19 @@ bool EditingBehavior::ShouldInsertCharacter(const KeyboardEvent& event) const {
- // unexpected behaviour
- if (ch < ' ')
- return false;
- -#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
- +//#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
- // According to XKB map no keyboard combinations with ctrl key are mapped to
- // printable characters, however we need the filter as the DomKey/text could
- // contain printable characters.
- - if (event.ctrlKey())
- - return false;
- -#elif !BUILDFLAG(IS_WIN)
- + //if (event.ctrlKey())
- + // return false;
- +#if !BUILDFLAG(IS_WIN)
- // Don't insert ASCII character if ctrl w/o alt or meta is on.
- // On Mac, we should ignore events when meta is on (Command-<x>).
- if (ch < 0x80) {
- if (event.ctrlKey() && !event.altKey())
- return false;
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- if (event.metaKey())
- return false;
- #endif
- diff --git a/ui/base/window_open_disposition.cc b/ui/base/window_open_disposition.cc
- index 0c3708f6b..8eed78e74 100644
- --- a/ui/base/window_open_disposition.cc
- +++ b/ui/base/window_open_disposition.cc
- @@ -17,7 +17,7 @@ WindowOpenDisposition DispositionFromClick(
- bool shift_key,
- WindowOpenDisposition disposition_for_current_tab) {
- // MacOS uses meta key (Command key) to spawn new tabs.
- -#if BUILDFLAG(IS_APPLE)
- +#if BUILDFLAG(IS_APPLE) || BUILDFLAG(IS_LINUX)
- if (middle_button || meta_key)
- #else
- if (middle_button || ctrl_key)
- diff --git a/ui/events/base_event_utils.cc b/ui/events/base_event_utils.cc
- index 294b52d76..104976d7a 100644
- --- a/ui/events/base_event_utils.cc
- +++ b/ui/events/base_event_utils.cc
- @@ -20,7 +20,7 @@ namespace {
-
- #if BUILDFLAG(IS_CHROMEOS_ASH)
- const int kSystemKeyModifierMask = EF_ALT_DOWN | EF_COMMAND_DOWN;
- -#elif BUILDFLAG(IS_APPLE)
- +#elif BUILDFLAG(IS_APPLE) || BUILDFLAG(IS_LINUX)
- // Alt modifier is used to input extended characters on Mac.
- const int kSystemKeyModifierMask = EF_COMMAND_DOWN;
- #else
- diff --git a/ui/events/event_constants.h b/ui/events/event_constants.h
- index 5a7dfef91..7896ea956 100644
- --- a/ui/events/event_constants.h
- +++ b/ui/events/event_constants.h
- @@ -52,7 +52,7 @@ enum EventFlags {
- #if BUILDFLAG(IS_APPLE)
- EF_PLATFORM_ACCELERATOR = EF_COMMAND_DOWN,
- #else
- - EF_PLATFORM_ACCELERATOR = EF_CONTROL_DOWN,
- + EF_PLATFORM_ACCELERATOR = EF_COMMAND_DOWN,
- #endif
- };
-
- diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
- index 3d831cf69..c08768dcd 100644
- --- a/ui/views/controls/textfield/textfield.cc
- +++ b/ui/views/controls/textfield/textfield.cc
- @@ -241,9 +241,9 @@ Textfield::Textfield()
- // These allow BrowserView to pass edit commands from the Chrome menu to us
- // when we're focused by simply asking the FocusManager to
- // ProcessAccelerator() with the relevant accelerators.
- - AddAccelerator(ui::Accelerator(ui::VKEY_X, ui::EF_CONTROL_DOWN));
- - AddAccelerator(ui::Accelerator(ui::VKEY_C, ui::EF_CONTROL_DOWN));
- - AddAccelerator(ui::Accelerator(ui::VKEY_V, ui::EF_CONTROL_DOWN));
- + AddAccelerator(ui::Accelerator(ui::VKEY_X, ui::EF_PLATFORM_ACCELERATOR));
- + AddAccelerator(ui::Accelerator(ui::VKEY_C, ui::EF_PLATFORM_ACCELERATOR));
- + AddAccelerator(ui::Accelerator(ui::VKEY_V, ui::EF_PLATFORM_ACCELERATOR));
- #endif
-
- // Sometimes there are additional ignored views, such as the View representing
- @@ -2118,7 +2118,7 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
- return ui::TextEditCommand::INVALID_COMMAND;
-
- const bool shift = event.IsShiftDown();
- -#if BUILDFLAG(IS_MAC)
- +#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
- const bool command = event.IsCommandDown();
- #endif
- const bool control = event.IsControlDown() || event.IsCommandDown();
- @@ -2127,42 +2127,42 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
- case ui::VKEY_Z:
- if (control && !shift && !alt)
- return ui::TextEditCommand::UNDO;
- - return (control && shift && !alt) ? ui::TextEditCommand::REDO
- + return (command && shift && !alt) ? ui::TextEditCommand::REDO
- : ui::TextEditCommand::INVALID_COMMAND;
- case ui::VKEY_Y:
- - return (control && !alt) ? ui::TextEditCommand::REDO
- + return (command && !alt) ? ui::TextEditCommand::REDO
- : ui::TextEditCommand::INVALID_COMMAND;
- case ui::VKEY_A:
- - return (control && !alt) ? ui::TextEditCommand::SELECT_ALL
- + return (command && !alt) ? ui::TextEditCommand::SELECT_ALL
- : ui::TextEditCommand::INVALID_COMMAND;
- case ui::VKEY_X:
- - return (control && !alt) ? ui::TextEditCommand::CUT
- + return (command && !alt) ? ui::TextEditCommand::CUT
- : ui::TextEditCommand::INVALID_COMMAND;
- case ui::VKEY_C:
- - return (control && !alt) ? ui::TextEditCommand::COPY
- + return (command && !alt) ? ui::TextEditCommand::COPY
- : ui::TextEditCommand::INVALID_COMMAND;
- case ui::VKEY_V:
- - return (control && !alt) ? ui::TextEditCommand::PASTE
- + return (command && !alt) ? ui::TextEditCommand::PASTE
- : ui::TextEditCommand::INVALID_COMMAND;
- case ui::VKEY_RIGHT:
- // Ignore alt+right, which may be a browser navigation shortcut.
- if (alt)
- return ui::TextEditCommand::INVALID_COMMAND;
- if (!shift) {
- - return control ? ui::TextEditCommand::MOVE_WORD_RIGHT
- + return command ? ui::TextEditCommand::MOVE_WORD_RIGHT
- : ui::TextEditCommand::MOVE_RIGHT;
- }
- - return control ? ui::TextEditCommand::MOVE_WORD_RIGHT_AND_MODIFY_SELECTION
- + return command ? ui::TextEditCommand::MOVE_WORD_RIGHT_AND_MODIFY_SELECTION
- : ui::TextEditCommand::MOVE_RIGHT_AND_MODIFY_SELECTION;
- case ui::VKEY_LEFT:
- // Ignore alt+left, which may be a browser navigation shortcut.
- if (alt)
- return ui::TextEditCommand::INVALID_COMMAND;
- if (!shift) {
- - return control ? ui::TextEditCommand::MOVE_WORD_LEFT
- + return command ? ui::TextEditCommand::MOVE_WORD_LEFT
- : ui::TextEditCommand::MOVE_LEFT;
- }
- - return control ? ui::TextEditCommand::MOVE_WORD_LEFT_AND_MODIFY_SELECTION
- + return command ? ui::TextEditCommand::MOVE_WORD_LEFT_AND_MODIFY_SELECTION
- : ui::TextEditCommand::MOVE_LEFT_AND_MODIFY_SELECTION;
- case ui::VKEY_HOME:
- if (shift) {
- @@ -2233,12 +2233,12 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
- if (shift && control)
- return ui::TextEditCommand::DELETE_TO_END_OF_LINE;
- #endif
- - if (control)
- + if (command)
- return ui::TextEditCommand::DELETE_WORD_FORWARD;
- return shift ? ui::TextEditCommand::CUT
- : ui::TextEditCommand::DELETE_FORWARD;
- case ui::VKEY_INSERT:
- - if (control && !shift)
- + if (command && !shift)
- return ui::TextEditCommand::COPY;
- return (shift && !control) ? ui::TextEditCommand::PASTE
- : ui::TextEditCommand::INVALID_COMMAND;
|