Browse Source

english spelling in README and small changes

Paola Fontana Gasio 4 years ago
parent
commit
20b3cbcaca
3 changed files with 6 additions and 7 deletions
  1. 3 3
      README.md
  2. 1 1
      src/final-converter
  3. 2 3
      src/motiv_gen

+ 3 - 3
README.md

@@ -9,12 +9,12 @@ First of all you need [python3](https://www.python.org/downloads/) including the
 	pip install music21
 	pip install music21
 
 
 ## the 'gizmo notation'
 ## the 'gizmo notation'
-For a simple toolkit you need a simple notation that abides to the unix philsphoy. So we made a now one that consists simply of *lines in a plain text file*.
+For a simple toolkit you need a simple notation that abides to the unix philsphoy. So we made a new one that consists simply of *lines in a plain text file*.
 
 
-Every line contains the information about *one note*. Seperated by apostrophes there are different attributes specified for each note. Every attribute seperated like this is called a **'part'**:
+Every line contains the information about *one note*. Seperated by commas there are different attributes specified for each note. Every attribute seperated like this is called a **'part'**:
 
 
 - The first part is a four characters long float that contains the *length* of the note in quarters.
 - The first part is a four characters long float that contains the *length* of the note in quarters.
-- The second part is two to three chars long. The fist character is the Note value (capitalized) and the second one the octave (as a integer). The third char is optional and just the key signature in the form of either "#" or "-".
+- The second part is two to three chars long. The fist character is the note value (capitalized) and the second one the octave (as an integer). The third char is optional and just the key signature in the form of either "#" or "-".
 
 
 Here an example in the *gizmo notation*:
 Here an example in the *gizmo notation*:
 
 

+ 1 - 1
src/final-converter

@@ -7,7 +7,7 @@ import sys
 if sys.platform == 'linux':
 if sys.platform == 'linux':
     environment.set('musicxmlPath', '/usr/bin/musescore')
     environment.set('musicxmlPath', '/usr/bin/musescore')
 elif sys.platform == 'darwin':
 elif sys.platform == 'darwin':
-    environment.set('musicxmlPath', 'Applications/MuseScore 3.5.app/')
+    environment.set('musicxmlPath', '/Applications/MuseScore 3.5.app/')
 else:
 else:
     print("Error: Please Use a Unix-like Operating System or change the source code")
     print("Error: Please Use a Unix-like Operating System or change the source code")
     exit()
     exit()

+ 2 - 3
src/motiv_gen

@@ -45,7 +45,7 @@ try:
         raise ValueError("Number was too small (below 1)")
         raise ValueError("Number was too small (below 1)")
 except (IndexError, ValueError):
 except (IndexError, ValueError):
     # set fallback value if no or wrong arguments given
     # set fallback value if no or wrong arguments given
-    motiv_length_in_quarter_notes = 4
+    motiv_length_in_quarter_notes = random.randint(2,6)
 
 
 # get command line argument velocity
 # get command line argument velocity
 try:
 try:
@@ -55,7 +55,7 @@ try:
         raise ValueError("Number out of bounce (below 0 or over 2)")
         raise ValueError("Number out of bounce (below 0 or over 2)")
 except (IndexError, ValueError):
 except (IndexError, ValueError):
     # set fallback value if no or wrong arguments given
     # set fallback value if no or wrong arguments given
-    rythme_velocity = 2
+    rythme_velocity = random.randint(0,2)
 
 
 try:
 try:
     first_note = str(sys.argv[3])
     first_note = str(sys.argv[3])
@@ -101,7 +101,6 @@ if len(first_note) == 0:
     motiv[0] = motiv[0] + random.choice(notes_list) + str(int(round(random.normalvariate(4, 0.5),0)))
     motiv[0] = motiv[0] + random.choice(notes_list) + str(int(round(random.normalvariate(4, 0.5),0)))
 else:
 else:
     motiv[0] = motiv[0] + first_note
     motiv[0] = motiv[0] + first_note
-    print("motiv:", motiv[0])
 
 
 # compute remaining notes
 # compute remaining notes
 for i in range (1, len(motiv)):
 for i in range (1, len(motiv)):