libsecret-crash.patch 1.1 KB

1234567891011121314151617181920212223242526272829303132
  1. From 021cecbce289f1d9c68a156d5b8dd204a73bc715 Mon Sep 17 00:00:00 2001
  2. From: Christophe Fergeau <cfergeau@redhat.com>
  3. Date: Sun, 20 Dec 2015 20:51:52 +0100
  4. Subject: NetworkAgent: Fix double-unref in get_secrets_keyring_cb()
  5. In get_secrets_keyring_cb, we own a ref on the 'attributes' hash table
  6. from secret_item_get_attributes), and a ref on the 'secret' object (from
  7. secret_item_get_secret(), but in the SHELL_KEYRING_SK_TAG case, we unref
  8. these once before breaking out of the loop, and the second time after
  9. breaking out of the loop.
  10. https://bugzilla.gnome.org/show_bug.cgi?id=759708
  11. ---
  12. src/shell-network-agent.c | 2 --
  13. 1 file changed, 2 deletions(-)
  14. diff --git a/src/shell-network-agent.c b/src/shell-network-agent.c
  15. index 5d99167..da0f7e5 100644
  16. --- a/src/shell-network-agent.c
  17. +++ b/src/shell-network-agent.c
  18. @@ -314,8 +314,6 @@ get_secrets_keyring_cb (GObject *source,
  19. secrets_found = TRUE;
  20. - g_hash_table_unref (attributes);
  21. - secret_value_unref (secret);
  22. break;
  23. }
  24. }
  25. --
  26. cgit v0.11.2