Noah Vogt 3 lat temu
rodzic
commit
5221c275c5

+ 2 - 4
app/src/main/java/com/noahvogt/snailmail/data/MailFunctions.java

@@ -1,12 +1,12 @@
 package com.noahvogt.snailmail.data;
 
-import android.util.Patterns;
 import android.widget.EditText;
 
 import com.chaquo.python.PyObject;
 import com.chaquo.python.Python;
 
 import java.util.List;
+import java.util.regex.Pattern;
 
 public class MailFunctions {
 
@@ -121,7 +121,7 @@ public class MailFunctions {
         if (email.isEmpty()) {
             emailAddress.setError("Field can't be empty");
             return false;
-        } else if (!Patterns.EMAIL_ADDRESS.matcher(email).matches()) {
+        } else if (!Pattern.matches(".+@.+", email)) {
             emailAddress.setError("Please enter a valid email address");
             return false;
         } else {
@@ -144,13 +144,11 @@ public class MailFunctions {
 
     public static boolean validateSubject(EditText emailSubject) {
         String subject = emailSubject.getText().toString();
-        /* TODO: check email protocol specification for what is allowed for subjects */
         return true;
     }
 
     public static boolean validateMessageBody(EditText emailMessageBody) {
         String messageBody = emailMessageBody.getText().toString();
-        /* TODO: check email protocol specification for what is allowed for message bodies */
         return true;
     }
 

+ 0 - 1
app/src/main/java/com/noahvogt/snailmail/database/MessageDao.java

@@ -21,7 +21,6 @@ import java.util.List;
 @Dao
 public interface MessageDao {
 
-    // TODO: updating messages, search funktion, read in cc and bcc as list
     // allowing the insert of the same word multiple times by passing a
     // conflict resolution strategy
     @Insert(onConflict = OnConflictStrategy.IGNORE)

+ 0 - 9
app/src/main/java/com/noahvogt/snailmail/ui/editor/EditorFragment.java

@@ -101,15 +101,6 @@ public class EditorFragment extends DialogFragment implements PopupMenu.OnMenuIt
         return view;
     }
 
-    /* TODO: add useful functionality to the menu + consider not using Resource ID's in switch statement
-
-        IDEAS:
-        - clear all user input
-        - change / check email signature
-        - some email header hacking / options / customization
-        - mail server probing
-        - sending address spoofer ??
-    */
     @Override
     public boolean onMenuItemClick(MenuItem item) {
         switch (item.getItemId()) {

+ 0 - 4
app/src/main/java/com/noahvogt/snailmail/ui/mailboxes/draftFolder/DraftFragment.java

@@ -30,8 +30,6 @@ public class  DraftFragment extends Fragment implements CustomAdapter.SelectedMe
 
     public View onCreateView(@NonNull LayoutInflater inflater,
                              ViewGroup container, Bundle savedInstanceState) {
-
-
         recyclerView = MainActivity.recyclerView.findViewById(R.id.recyclerView);
 
         final CustomAdapter adapter = new CustomAdapter(new CustomAdapter.EmailDiff(), this);
@@ -58,12 +56,10 @@ public class  DraftFragment extends Fragment implements CustomAdapter.SelectedMe
         return root;
     }
 
-
     @Override
     public void selectedMessage(Message messages, EmailViewModel emailViewModel) {
         EditorFragment editorFragment = new EditorFragment();
 
-        //TODO: make this Fragment editable
         AppCompatActivity activity = (AppCompatActivity) getContext();
         DialogFragment dialog = editorFragment.getMessage(messages, emailViewModel, editorFragment);
         dialog.show(activity.getSupportFragmentManager(), "tag");

+ 0 - 6
app/src/main/java/com/noahvogt/snailmail/ui/reader/ReaderFragment.java

@@ -65,8 +65,6 @@ public class ReaderFragment extends DialogFragment implements PopupMenu.OnMenuIt
             }
         });
 
-
-
         ImageButton closeButton = view.findViewById(R.id.show_message_close_button);
         ImageButton dotButton = view.findViewById(R.id.show_message_dots_button);
         ImageButton attachButton = view.findViewById(R.id.show_message_attach_button);
@@ -87,7 +85,6 @@ public class ReaderFragment extends DialogFragment implements PopupMenu.OnMenuIt
         showDate.setText(mCurrent.getDate());
 
 
-        // TODO: add cc + bcc functionality
         showBccButton.setOnClickListener(v -> createNewPopup(true));
 
         showCCButton.setOnClickListener(v -> createNewPopup(false));
@@ -95,7 +92,6 @@ public class ReaderFragment extends DialogFragment implements PopupMenu.OnMenuIt
         closeButton.setOnClickListener(v -> dismiss());
 
         attachButton.setOnClickListener(v -> {
-            // TODO: add file attachment functionality
         });
 
         dotButton.setOnClickListener(v -> {
@@ -104,11 +100,9 @@ public class ReaderFragment extends DialogFragment implements PopupMenu.OnMenuIt
             popupMenu.inflate(R.menu.create_message_options_menu);
             popupMenu.show();
         });
-
         return view;
     }
 
-
     @Override
     public boolean onMenuItemClick(MenuItem item) {
         switch (item.getItemId()) {

+ 0 - 1
app/src/main/java/com/noahvogt/snailmail/workers/DownloadWorker.java

@@ -29,7 +29,6 @@ import static com.noahvogt.snailmail.MainActivity.mEmailViewModel;
 
 public class DownloadWorker extends Worker {
 
-    //TODO: upload every data to server
     public DownloadWorker(
             @NonNull Context appContext,
             @NonNull WorkerParameters workerParameters){