add-a-TODO-about-a-missing-pnacl-flag.patch 1.2 KB

12345678910111213141516171819202122232425262728
  1. From 7a23987acb698c2934958cb42a5e7b1cd73fe142 Mon Sep 17 00:00:00 2001
  2. From: Nico Weber <thakis@chromium.org>
  3. Date: Tue, 20 Jul 2021 21:54:09 +0000
  4. Subject: [PATCH] build: Add a TODO about a missing pnacl flag
  5. Change-Id: I1700d185a23afe4120e14c755782450b1bf89289
  6. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041785
  7. Commit-Queue: Nico Weber <thakis@chromium.org>
  8. Commit-Queue: Hans Wennborg <hans@chromium.org>
  9. Auto-Submit: Nico Weber <thakis@chromium.org>
  10. Reviewed-by: Hans Wennborg <hans@chromium.org>
  11. Cr-Commit-Position: refs/heads/master@{#903659}
  12. ---
  13. build/config/compiler/BUILD.gn | 1 +
  14. 1 file changed, 1 insertion(+)
  15. diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
  16. index b6e095b705..ef6d1dfc12 100644
  17. --- a/build/config/compiler/BUILD.gn
  18. +++ b/build/config/compiler/BUILD.gn
  19. @@ -1217,6 +1217,7 @@ config("compiler_deterministic") {
  20. # we build same files with same compile flag.
  21. # Other paths are already given in relative, no need to normalize them.
  22. if (is_nacl) {
  23. + # TODO(https://crbug.com/1231236): Use -ffile-compilation-dir= here.
  24. cflags += [
  25. "-Xclang",
  26. "-fdebug-compilation-dir",