force-mp3-files-to-have-a-start-time-of-zero.patch 1.6 KB

1234567891011121314151617181920212223242526272829303132333435363738
  1. From 192fc3899f76e9487d77895f31df8d2d13bf9619 Mon Sep 17 00:00:00 2001
  2. From: Dale Curtis <dalecurtis@chromium.org>
  3. Date: Fri, 26 Jun 2020 01:10:55 +0000
  4. Subject: [PATCH] Force mp3 files to have a start time of zero.
  5. This will allow us to remove our custom patch which breaks upstream
  6. ffmpeg functionality for unknown reasons.
  7. R=sandersd
  8. Fixed: 1062037
  9. Change-Id: I253011843dee4dd6a8c958b14990ad836a9f1dca
  10. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268221
  11. Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
  12. Reviewed-by: Dan Sanders <sandersd@chromium.org>
  13. Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
  14. Cr-Commit-Position: refs/heads/master@{#782792}
  15. ---
  16. media/filters/ffmpeg_demuxer.cc | 6 ++++++
  17. 1 file changed, 6 insertions(+)
  18. diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc
  19. index 01266e1a072..a7ed542b5fc 100644
  20. --- a/media/filters/ffmpeg_demuxer.cc
  21. +++ b/media/filters/ffmpeg_demuxer.cc
  22. @@ -1522,6 +1522,12 @@ void FFmpegDemuxer::OnFindStreamInfoDone(int result) {
  23. if (glue_->container() == container_names::CONTAINER_AVI)
  24. format_context->flags |= AVFMT_FLAG_GENPTS;
  25. + // FFmpeg will incorrectly adjust the start time of MP3 files into the future
  26. + // based on discard samples. We were unable to fix this upstream without
  27. + // breaking ffmpeg functionality. https://crbug.com/1062037
  28. + if (glue_->container() == container_names::CONTAINER_MP3)
  29. + start_time_ = base::TimeDelta();
  30. +
  31. // For testing purposes, don't overwrite the timeline offset if set already.
  32. if (timeline_offset_.is_null()) {
  33. timeline_offset_ =