remove-dead-reloc-in-nonalloc-LD-flags.patch 1.4 KB

12345678910111213141516171819202122232425262728293031323334353637
  1. From 74b0cb5b86f7d7f8f7c1172d85b09096bef147b7 Mon Sep 17 00:00:00 2001
  2. From: Daniel Nicoara <dnicoara@chromium.org>
  3. Date: Thu, 24 Sep 2020 02:34:24 +0000
  4. Subject: [PATCH] Remove dead-reloc-in-nonalloc LD flags
  5. Breakpad change landed. Revert workaround.
  6. Bug: 1105559
  7. Test: components/crash/content/tools/generate_breakpad_symbols.py --build-dir=out/andrd --binary=out/andrd/lib.unstripped/libcontent_shell_content_view.so --symbols-dir=/tmp/foo --platform=android
  8. Change-Id: I519534002898a97b15a57b9b87ac78ef3f216dee
  9. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427349
  10. Commit-Queue: Nico Weber <thakis@chromium.org>
  11. Reviewed-by: Nico Weber <thakis@chromium.org>
  12. Cr-Commit-Position: refs/heads/master@{#810066}
  13. ---
  14. build/config/compiler/BUILD.gn | 8 --------
  15. 1 file changed, 8 deletions(-)
  16. diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
  17. index aa9eca20bd2..42839cfba3f 100644
  18. --- a/build/config/compiler/BUILD.gn
  19. +++ b/build/config/compiler/BUILD.gn
  20. @@ -396,14 +396,6 @@ config("compiler") {
  21. "-Wl,--as-needed",
  22. ]
  23. }
  24. - if (use_lld && !is_chromeos_device) {
  25. - # TODO(thakis): Fix dump_syms to not need this and then remove it,
  26. - # https://crbug.com/1105559
  27. - ldflags += [
  28. - "-Wl,-z,dead-reloc-in-nonalloc=*=0",
  29. - "-Wl,-z,dead-reloc-in-nonalloc=.debug_ranges=1",
  30. - ]
  31. - }
  32. }
  33. # Linux-specific compiler flags setup.